Merge branch 'main' into bye-bye-tsserverlibrary

Author: jakebailey

.devcontainer/Dockerfile

@@ -1,7 +1,7 @@
-# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.154.0/containers/javascript-node/.devcontainer/base.Dockerfile
+# See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/v0.245.2/containers/javascript-node/.devcontainer/base.Dockerfile
 
-# [Choice] Node.js version: 14, 12, 10
-ARG VARIANT="14-buster"
+# [Choice] Node.js version: 18, 16, 14
+ARG VARIANT="18-buster"
 FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
 
 RUN sudo -u node npm install -g hereby

.devcontainer/devcontainer.json

@@ -3,20 +3,24 @@
     "build": {
         "dockerfile": "Dockerfile",
         "args": {
-            "VARIANT": "14"
+            "VARIANT": "18"
         }
     },
-    "settings": {
-        "terminal.integrated.defaultProfile.linux": "bash",
-        "terminal.integrated.profiles.linux": {
-            "bash": {
-                "path": "/bin/bash",
-                "icon": "terminal-bash",
+    "customizations": {
+        "vscode": {
+            "settings": {
+                "terminal.integrated.defaultProfile.linux": "bash",
+                "terminal.integrated.profiles.linux": {
+                    "bash": {
+                        "path": "/bin/bash",
+                        "icon": "terminal-bash"
+                    }
+                }
             },
-        },
+            "extensions": [
+                "dbaeumer.vscode-eslint"
+            ]
+        }
     },
-    "extensions": [
-        "dbaeumer.vscode-eslint"
-    ],
     "remoteUser": "node"
-}
+}

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -12,6 +12,11 @@ body:
         What search terms did you use when trying to find an existing bug report?
 
         List them here so people in the future can find this one more easily.
+      placeholder: |
+        List of keywords you searched for before creating this issue.
+        Write them down here so that others can find this bug more easily and help provide feedback.
+
+        e.g. "function inference any", "jsx attribute spread", "move to file duplicate imports", "discriminated union inference", "ts2822"
     validations:
       required: true
   - type: textarea
@@ -72,6 +77,10 @@ body:
           - We have to pare too much extraneous code.
           - We have to clone a large repo and validate that the problem isn't elsewhere.
           - The sample is confusing or doesn't clearly demonstrate what's wrong.
+      value: |
+        ```ts
+        // Your code here
+        ```
     validations:
       required: false
   - type: textarea

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -17,6 +17,8 @@ body:
       placeholder: |
         List of keywords you searched for before creating this issue.
         Write them down here so that others can find this suggestion more easily and help provide feedback.
+
+        e.g. "isArray readonly", "regex string types", "json const assertion import"
     validations:
       required: true
   - type: checkboxes

Herebyfile.mjs

@@ -14,7 +14,7 @@ import util from "util";
 import { localizationDirectories } from "./scripts/build/localization.mjs";
 import cmdLineOptions from "./scripts/build/options.mjs";
 import { buildProject, cleanProject, watchProject } from "./scripts/build/projects.mjs";
-import { localBaseline, localRwcBaseline, refBaseline, refRwcBaseline, runConsoleTests } from "./scripts/build/tests.mjs";
+import { localBaseline, refBaseline, runConsoleTests } from "./scripts/build/tests.mjs";
 import { Debouncer, Deferred, exec, getDiffTool, memoize, needsUpdate, readJson } from "./scripts/build/utils.mjs";
 
 const glob = util.promisify(_glob);
@@ -766,12 +766,6 @@ export const diff = task({
     run: () => exec(getDiffTool(), [refBaseline, localBaseline], { ignoreExitCode: true, waitForExit: false }),
 });
 
-export const diffRwc = task({
-    name: "diff-rwc",
-    description: "Diffs the RWC baselines using the diff tool specified by the 'DIFF' environment variable",
-    run: () => exec(getDiffTool(), [refRwcBaseline, localRwcBaseline], { ignoreExitCode: true, waitForExit: false }),
-});
-
 /**
  * @param {string} localBaseline Path to the local copy of the baselines
  * @param {string} refBaseline Path to the reference copy of the baselines
@@ -806,12 +800,6 @@ export const baselineAccept = task({
     run: baselineAcceptTask(localBaseline, refBaseline),
 });
 
-export const baselineAcceptRwc = task({
-    name: "baseline-accept-rwc",
-    description: "Makes the most recent rwc test results the new baseline, overwriting the old baseline",
-    run: baselineAcceptTask(localRwcBaseline, refRwcBaseline),
-});
-
 // TODO(rbuckton): Determine if we still need this task. Depending on a relative
 //                 path here seems like a bad idea.
 export const updateSublime = task({
@@ -825,13 +813,6 @@ export const updateSublime = task({
     }
 });
 
-// TODO(rbuckton): Should the path to DefinitelyTyped be configurable via an environment variable?
-export const importDefinitelyTypedTests = task({
-    name: "importDefinitelyTypedTests",
-    description: "Runs the importDefinitelyTypedTests script to copy DT's tests to the TS-internal RWC tests",
-    run: () => exec(process.execPath, ["scripts/importDefinitelyTypedTests.mjs", "./", "../DefinitelyTyped"]),
-});
-
 
 export const produceLKG = task({
     name: "LKG",