Skip to content

Better visual distinction between --pretty --watch recompile results? #20379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Nov 30, 2017 · 5 comments
Closed
Labels
Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript

Comments

@JoshuaKGoldberg
Copy link
Contributor

JoshuaKGoldberg commented Nov 30, 2017

TypeScript Version: 2.7.0-dev.20171126

While running tsc --pretty --watch, there's not much visual distinction between different rounds of failures. Other than a few blank lines on the right half of the screen, they look very similar. When I have a lot of files I'm going through refactor errors through it can be hard to tell what's fixed or fresh.

image

For comparison, this is what TSLint's stylish formatter outputs...

image

...and this is what gulp outputs:

image


A few suggestions to make this display easier to read (replace "grey" with any non-white color):

  • Use grey text for line/column numbers and/or grey+bold text for TS2451-style identifiers
  • Use grey text for times
  • Use grey and/or italic text for File change detected. lines
  • In the Compilation complete. lines:
    • Say whether compilation failed or succeeded
    • Use green or red text appropriately
  • Add a CLI option to clear the console when a new run starts
@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2017

Would #17756 address the issue?

@JoshuaKGoldberg
Copy link
Contributor Author

Console clearing would make things much better!...

...but it would still be nice to have the more readable colors. This issue would just be much less important.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2017

#17756 is waiting on one small change, if you want to pick it up and get it in would be happy to merge it.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2017

Also PRs for additional colors for errors message with --pretty are welcomed.

@mhegazy mhegazy added Suggestion An idea for TypeScript Help Wanted You can do this Good First Issue Well scoped, documented and has the green light labels Dec 1, 2017
@mhegazy mhegazy added this to the Community milestone Dec 1, 2017
@JoshuaKGoldberg
Copy link
Contributor Author

I'll try to add the colors in ASAP! :)

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Dec 2, 2017
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.7 Dec 2, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

2 participants