this and typeof are not type keywords in completions

[sandersn]

In services/utilities.ts:1213, this and typeof are not in

    export const typeKeywords: ReadonlyArray<SyntaxKind> = [
        SyntaxKind.AnyKeyword,
        SyntaxKind.BigIntKeyword,
        SyntaxKind.BooleanKeyword,
        SyntaxKind.FalseKeyword,
        SyntaxKind.KeyOfKeyword,
        SyntaxKind.NeverKeyword,
        SyntaxKind.NullKeyword,
        SyntaxKind.NumberKeyword,
        SyntaxKind.ObjectKeyword,
        SyntaxKind.ReadonlyKeyword,
        SyntaxKind.StringKeyword,
        SyntaxKind.SymbolKeyword,
        SyntaxKind.TrueKeyword,
        SyntaxKind.VoidKeyword,
        SyntaxKind.UndefinedKeyword,
        SyntaxKind.UniqueKeyword,
        SyntaxKind.UnknownKeyword,
    ];

even though they are type keywords. Unfortunately, adding them breaks some tests to do with find-all-refs with global this -- patterns like function f(this) { this } start identifying the this inside the function as the global this.

[fatcerberus]

function f(this) { this }

Isn’t this a syntax error?

[sandersn]

In JS yes, in TS no. TS allows the first parameter to be this in order to specify the type of this inside the function.

[fatcerberus]

Ah right - I knew about the this parameter but didn’t make the connection since that would be an automatic noImplicitAny error - not used to seeing bare parameters anymore 😃

[jakebailey]

This was half-fixed in #53325, but things do still fail as described if you just add ThisKeyword without other changes.

[gabritto]

Noticed this today and it is very annoying to be typing this in a type position and pressing a commit character, only to see some global type accepted as completion, e.g:

interface Foo {
        foo(): this|
}

if you then press ;, which is a commit character, we autocomplete with some type:

interface F {
        foo(): ThisParameterType;
}