type and namespace no longer appear as global keyword completion

[uniqueiniquity]

TypeScript Version: 3.6.2

Search Terms:
keyword, completion, global, namespace

Code

n

Expected behavior:
Completion gives namespace.

Actual behavior:
Completion does not give namespace.

Playground Link: N/A

Related Issues:
Broken by #32474
See https://developercommunity.visualstudio.com/content/problem/749982/typescript-intellisense-is-incorrect-for-namespace.html for report.

[DanielRosenwasser]

Uh, should the type keyword be included too? Seems that list was too eager.

[simplywondrous]

@sandersn Can I try working on this?

[sandersn]

Sure! I re-reviewed the change and I think it was the drive-by fix in getTypescriptKeywordCompletions that made this happen; the code was clearly not operating as intended since it was truthy-checking a kind property. But I don't think the code that was there was correct either.

I noticed that I added declare,module and functionlike-body-keyword to the existing code. So probably you have to add namespace to the list plus any other keyword that got removed that you want to put back.

Ping me @DanielRosenwasser and @andrewbranch on the review when it's ready.

[sandersn]

@simplywondrous since the beta ends next Monday, I'm going to go ahead and do this.