Skip to content

TypeError: Cannot read property 'kind' of undefined in vscode build #36614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JacksonKearl opened this issue Feb 4, 2020 · 3 comments · Fixed by #36619
Closed

TypeError: Cannot read property 'kind' of undefined in vscode build #36614

JacksonKearl opened this issue Feb 4, 2020 · 3 comments · Fixed by #36619
Labels
Duplicate An existing issue was already created

Comments

@JacksonKearl
Copy link

JacksonKearl commented Feb 4, 2020

Branch up at https://github.com/microsoft/vscode/tree/jackson/ts-build-error

When I run the typescript build, it crashes with the below error:

TypeError: Cannot read property 'kind' of undefined
    at getErrorSpanForNode (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:13429:22)
    at createDiagnosticForNodeInSourceFile (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:13389:20)
    at Object.createDiagnosticForNode (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:13380:16)
    at reportNonExportedMember (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:36179:50)
    at getExternalModuleMember (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:36160:33)
    at getTargetOfImportSpecifier (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:36187:20)
    at getTargetOfAliasDeclaration (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:36238:28)
    at resolveAlias (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:36277:30)
    at checkAliasSymbol (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:64208:26)
    at checkImportBinding (/Users/jkearl/Developer/vscode/node_modules/typescript/lib/typescript.js:64240:13)
@JacksonKearl
Copy link
Author

Deleting line

import { SearchConfiguration, DEFAULT_SEARCH_CONFIG } from 'vs/workbench/contrib/searchEditor/browser/searchEditorInput';

from searchEditorModel and searchEditorSerialization fixes.

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output labels Feb 4, 2020
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.8.2 milestone Feb 4, 2020
@DanielRosenwasser
Copy link
Member

Probably due to #36187. I'm going to guess that using valueDeclaration instead of the first local declaration is a problem for types, uninstantiated namespaces, and imports (aliases).

@andrewbranch
Copy link
Member

andrewbranch commented Feb 5, 2020

Duplicate of #36592 (though I forgot to include the stack trace there), and Daniel is correct in the diagnosis 😁

@DanielRosenwasser DanielRosenwasser removed Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output labels Feb 5, 2020
@DanielRosenwasser DanielRosenwasser removed this from the TypeScript 3.8.2 milestone Feb 5, 2020
@DanielRosenwasser DanielRosenwasser added the Duplicate An existing issue was already created label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants