Skip to content

Method signature completion doesn't respect the custom indent size #47044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tyriar opened this issue Dec 1, 2021 · 3 comments
Open

Method signature completion doesn't respect the custom indent size #47044

Tyriar opened this issue Dec 1, 2021 · 3 comments
Labels
Bug A bug in TypeScript
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 1, 2021

Using Spaces: 2, there are 6 spaces in the gif below when there should only be 4
recording (5)

@mjbvz mjbvz transferred this issue from microsoft/vscode Dec 6, 2021
@mjbvz mjbvz changed the title TypeScript fill in abstract implementation doesn't respect the indent style Method signature completion doesn't respect the custom indent size Dec 6, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Dec 6, 2021

Minimal repo:

class Base {
  foo() { }
}

class Sub extends Base {
  
}
  1. Change indentation to 2 spaces
  2. Complete foo inside of sub

Bug
The body is still indented by four spaces

@mjbvz mjbvz removed their assignment Dec 6, 2021
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Dec 7, 2021
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Dec 7, 2021
@RyanCavanaugh
Copy link
Member

@gabritto FYI in case you want to reschedule sooner

@gabritto
Copy link
Member

gabritto commented Dec 7, 2021

might be solved by #46832 since that PR makes it so we call the formatter for the completion text, but I'm going to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript
Projects
None yet
Development

No branches or pull requests

4 participants