Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Dropdown align auto controlled props with Downshift #791

Closed
silviuaavram opened this issue Jan 29, 2019 · 2 comments
Closed

Dropdown align auto controlled props with Downshift #791

silviuaavram opened this issue Jan 29, 2019 · 2 comments
Assignees
Labels
⚙️ enhancement New feature or request vsts Paired with ticket in vsts

Comments

@silviuaavram
Copy link
Collaborator

For example, Downshift has highlightedIndex, defaultHighlightedIndex and initialHighlightedIndex. In order to expose highlightedIndex as Dropdown autocontrolled prop, some mapping needs to be done between that and the one in Downshift.

Also, default is something we consider as initial as far as Downshift is concerned.

Follow up from #726

@silviuaavram silviuaavram self-assigned this Jan 29, 2019
@silviuaavram silviuaavram added the ⚙️ enhancement New feature or request label Jan 29, 2019
@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Jan 29, 2019
@bmdalex
Copy link
Collaborator

bmdalex commented Jan 30, 2019

Also we should make isOpen and defaultIsOpen auto controlled props as we started using the flag internally in #786

@jurokapsiar
Copy link
Contributor

Closing, according to @silviuavram "we will continue to have different behavior with initial and default in Downshift and Dropdown"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ enhancement New feature or request vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

4 participants