Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a specific reason for not using forkpty on macOS? #590

Closed
tamuratak opened this issue Apr 2, 2023 · 1 comment
Closed

Is there a specific reason for not using forkpty on macOS? #590

tamuratak opened this issue Apr 2, 2023 · 1 comment

Comments

@tamuratak
Copy link

tamuratak commented Apr 2, 2023 •
edited
Loading

Hi,

With #587, forkpty is not used on macOS, used only on Linux. It would increase the maintenance burden. forkpty is also available on macOS.

It seems to work just by removing lines in pty.cc for macOS. The following branch passes tests on macOS.

ProductName: macOS
ProductVersion: 11.7.5
BuildVersion: 20G1225

$ node -v
v16.19.1
@tamuratak tamuratak changed the title Is there a specific reason not using forkpty on macOS? Is there a specific reason for not using forkpty on macOS? Apr 2, 2023
@tamuratak
Copy link
Author

#476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tamuratak