Skip to content

Commit 9bb271d

Browse files
debontekimadeline
andcommitted
Apply suggestions from code review
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
1 parent 752622d commit 9bb271d

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/client/languageServer/watcher.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,10 @@ export class LanguageServerWatcher
187187
}
188188

189189
public async restartLanguageServers(): Promise<void> {
190-
const workspacesUris = this.workspaceService.workspaceFolders?.map((workspace) => workspace.uri) ?? [];
191-
192-
workspacesUris.forEach(async (resource) => {
193-
const lsResource = this.getWorkspaceUri(resource);
190+
this.workspaceLanguageServers.forEach(async (_, resourceString) => {
191+
const resource = Uri.parse(resourceString);
194192
this.stopLanguageServer(resource);
195-
await this.startLanguageServer(this.languageServerType, lsResource);
193+
await this.startLanguageServer(this.languageServerType, resource);
196194
});
197195
}
198196

src/client/telemetry/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,6 +1413,10 @@ export interface IEventNamePropertyMapping {
14131413
* Telemetry event sent when the installed versions of Python, Jupyter, and Pylance are all capable
14141414
* of supporting the LSP notebooks experiment. This does not indicate that the experiment is enabled.
14151415
*/
1416+
1417+
/* __GDPR__
1418+
"python_experiments_lsp_notebooks" : { "owner": "luabud" }
1419+
*/
14161420
[EventName.PYTHON_EXPERIMENTS_LSP_NOTEBOOKS]: unknown;
14171421
/**
14181422
* Telemetry event sent once on session start with details on which experiments are opted into and opted out from.

0 commit comments

Comments
 (0)