-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Replace walkthrough screenshots with SVGs #16811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@digitarald Do you know if we can we define different markdown files per theme? Or have some custom logic in the markdown file to display a different image depending on the theme? |
The best solution is using SVG's with color variables to adjust to the specific theme. Absent that, we don't currently have a way to swap out markdown images based on theme. While we support it for plain images, it tends to increase development and maintenance burden (you need to create and update three different images per step), with less impact than the SVGs as there's still only light/dark to pick from rather than theme specific coloring. If you think it's important I can look into a way to select images based on color. |
I think this can be considered a rough edge for now until we get time to request SVGs be made for us. |
@lydiayschung thank you so much Lydia!!! 🤩 |
Closing as now our walkthrough has SVGs that honor the theme. |
Testing #16796
Run and debug screenshot does not honour the current theme:
The text was updated successfully, but these errors were encountered: