Skip to content

Wrong formatting edits applied when running "Format Notebook" #17169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roblourens opened this issue Aug 31, 2021 · 1 comment
Closed

Wrong formatting edits applied when running "Format Notebook" #17169

roblourens opened this issue Aug 31, 2021 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@roblourens
Copy link
Member

Environment data

  • VS Code version: 1.60 insiders
  • Extension version (available under the Extensions sidebar): v2021.8.1159798656
  • OS and version: macOS

Steps

  • Open a notebook
  • Right click on a cell editor and run "Format Notebook"
  • The same edit gets applied to all cells

I don't know but I suspect the problem is with using .fileName for these temp files. That doesn't include the cell, so when we call this for all cells, it probably reuses the same temp file

https://vscode.dev/github/microsoft/vscode-python/blob/7adee50afc79ad0875044a78e1158249859f200b/src/client/formatters/baseFormatter.ts#L128-L128

Aug-31-2021 09-15-45

Downstream microsoft/vscode#131342

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Aug 31, 2021
@karthiknadig
Copy link
Member

duplicate of #16980

@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Aug 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants