Skip to content

Shrink extension size for github.dev by only including modules which are used in tsconfig.browser.json #17709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karrtikr opened this issue Oct 12, 2021 · 1 comment
Closed

Shrink extension size for github.dev by only including modules which are used in tsconfig.browser.json #17709

karrtikr opened this issue Oct 12, 2021 · 1 comment
Assignees
@karrtikr
Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality

Comments

@karrtikr
Copy link

When running in browser we only need to include what src\client\browser\extension.ts imports. It uses certain file system tools, common modules like localize.ts.

With #17658 it was expanded a lot more than needed.
@karrtikr karrtikr added feature-request Request for new features or functionality needs PR area-internal Label for non-user facing issues labels Oct 12, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 12, 2021
@karrtikr karrtikr changed the title Shrink extension size for github.dev by only including modules which are used for tsconfig.browser.json Shrink extension size for github.dev by only including modules which are used in tsconfig.browser.json Oct 12, 2021
@karrtikr karrtikr self-assigned this Oct 12, 2021
@karrtikr karrtikr removed the triage-needed Needs assignment to the proper sub-team label Oct 12, 2021
@karrtikr
Copy link
Author

#17658 was corrected.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karrtikr