Skip to content

"rename" on missing property shows empty warning popup #59426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roblourens opened this issue Sep 26, 2018 · 1 comment
Closed

"rename" on missing property shows empty warning popup #59426

roblourens opened this issue Sep 26, 2018 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2018

Comments

@roblourens
Copy link
Member

image

  • Access a property that doesn't exist
  • Press F2 to rename
  • See blue popup warning but it seems to have no warning message
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2018
@mjbvz mjbvz mentioned this issue Sep 26, 2018
Closed
@mjbvz mjbvz added this to the September 2018 milestone Sep 26, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 26, 2018

Root cause is microsoft/TypeScript#27373

But we should handle errors more gracefully here. Will fix that for September

@mjbvz mjbvz closed this as completed in cd7726d Sep 26, 2018
@mjbvz mjbvz mentioned this issue Sep 26, 2018
Closed
@octref octref added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@roblourens @octref @mjbvz