Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to compare project file with clipboard #7278

Closed
xianxingg opened this issue Jun 7, 2016 · 7 comments · Fixed by #37841
Closed

Allow to compare project file with clipboard #7278

xianxingg opened this issue Jun 7, 2016 · 7 comments · Fixed by #37841
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@xianxingg
Copy link

when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient.

It'll be great if i can copy the content of the online file, and right-click the local file, and choose "compare with clipboard".

@Tyriar
Copy link
Member

Tyriar commented Jun 7, 2016

An extension would be ideal for a feature like this.

@alexdima alexdima added the feature-request Request for new features or functionality label Jun 7, 2016
@alexdima
Copy link
Member

alexdima commented Jun 7, 2016

@bpasero fyi

@bpasero bpasero added the file-explorer Explorer widget issues label Jun 7, 2016
@bpasero bpasero added this to the Backlog milestone Jun 7, 2016
@bpasero bpasero self-assigned this Jun 7, 2016
@bpasero bpasero changed the title Request feature "Compare project file with clipboard" Allow to compare project file with clipboard Jun 7, 2016
@bpasero bpasero removed their assignment Aug 17, 2016
@jmconde
Copy link

jmconde commented Sep 14, 2016

It would be great too if also is allowed to compare selection with clipboard.

@JCorrivo
Copy link

It would be great if we could compare unsaved files...

@bpasero bpasero added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels May 30, 2017
@bpasero
Copy link
Member

bpasero commented May 30, 2017

I would be open to a PR here, I think it is not a lot of work. Some pointers:

  • register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: saveErrorHandler)
  • register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to CompareResourcesAction)

Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed.

Related to #358

@raghav710
Copy link

Has someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?

@bpasero
Copy link
Member

bpasero commented Jul 7, 2017

@raghav710 not yet, but it seems @tfriem has started a similar PR in #30210 which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.

@bpasero bpasero added the verification-needed Verification of issue is requested label Nov 10, 2017
@bpasero bpasero modified the milestones: Backlog, November 2017 Nov 10, 2017
@bpasero bpasero self-assigned this Nov 27, 2017
@alexdima alexdima added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants