test_runner: fix tick processing terminating prematurely

mika-fischer · mika-fischer · commit eee8da913444 · 2023-10-25T12:03:46.000+02:00
An incorrect early return caused processing of due timers to stop prematurely. Fixes: nodejs#50382
diff --git a/lib/internal/test_runner/mock/mock_timers.js b/lib/internal/test_runner/mock/mock_timers.js
@@ -624,7 +624,6 @@ class MockTimers {
       if (timer.interval) {
         timer.runAt += timer.interval;
         this.#executionQueue.insert(timer);
-        return;
       }
 
       timer = this.#executionQueue.peek();

Original file line number	Diff line number	Diff line change
`@@ -624,7 +624,6 @@ class MockTimers {`
`624`	`624`	`if (timer.interval) {`
`625`	`625`	`timer.runAt += timer.interval;`
`626`	`626`	`this.#executionQueue.insert(timer);`
`627`		`- return;`
`628`	`627`	`}`
`629`	`628`
`630`	`629`	`timer = this.#executionQueue.peek();`