Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings in master #42

Open
johannadevos opened this issue Mar 23, 2018 · 2 comments
Open

Deprecation warnings in master #42

johannadevos opened this issue Mar 23, 2018 · 2 comments
Assignees

Comments

@johannadevos
Copy link
Member

DeprecationWarning: This module was deprecated in version 0.18 in favor of the model_selection module into which all the refactored classes and functions are moved. Also note that the interface of the new CV iterators are different from that of this module. This module will be removed in 0.20.
"This module will be removed in 0.20.", DeprecationWarning)

Also check if there are other deprecation warnings - I think I saw another one but I'm not sure.

@johannadevos
Copy link
Member Author

I looked into this deprecation warning and don't think there is much we can do.

It arises when importing StratifiedKFold from sklearn.cross_validation (see below). However, this method is needed to make the code work when working with Python 3.5, and working with Python 3.5 in turn is needed to make TensorFlow work (at least on Windows). So I don't see how this could be fixed... Thoughts?

if sys.version_info >= (3, 6):
    from sklearn.model_selection import StratifiedKFold
else:  # We have an old version of sklearn...
    from sklearn.cross_validation import StratifiedKFold

@twesterhout
Copy link
Member

There is, it should already be fixed in gnnc branch. Not sure why it's not in master yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants