We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 6a43ed9 commit 4ca8c5eCopy full SHA for 4ca8c5e
src/pbrt/util/scattering.h
@@ -188,6 +188,11 @@ class TrowbridgeReitzDistribution {
188
189
std::string ToString() const;
190
191
+ // Note that this should probably instead be "return Sqr(roughness)" to
192
+ // be more perceptually uniform, though this wasn't noticed until some
193
+ // time after pbrt-v4 shipped: https://github.com/mmp/pbrt-v4/issues/479.
194
+ // therefore, we will leave it as is so that the rendered results with
195
+ // existing pbrt-v4 scenes doesn't change unexpectedly.
196
PBRT_CPU_GPU
197
static Float RoughnessToAlpha(Float roughness) { return std::sqrt(roughness); }
198
0 commit comments