Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no ambient occlusion (AO) effect in the corner. #485

Open
gladiator-hy opened this issue Feb 10, 2025 · 5 comments
Open

There is no ambient occlusion (AO) effect in the corner. #485

gladiator-hy opened this issue Feb 10, 2025 · 5 comments

Comments

@gladiator-hy
Copy link

gladiator-hy commented Feb 10, 2025

Image

This is the image rendered by PBRT. There is no ambient occlusion (AO) effect in the corner, and it even looks a bit bright.
What should I do?

@mmp
Copy link
Owner

mmp commented Feb 10, 2025

The most likely explanation is that that is an accurate rendering of the scene. If you think there is a bug in pbrt's path tracer, try to find a very simple example scene that shows that there is a bug.

@gladiator-hy
Copy link
Author

gladiator-hy commented Feb 11, 2025

Image
This time, I only used a simple model.

Here is my pbrt file. "skybox.exr" is too large, and the upload failed.
AO.zip

@gladiator-hy
Copy link
Author

After some time of thinking, I think it's because there is light leakage at the corner of the wall. Is this a problem that a path tracer cannot avoid?

@mmp
Copy link
Owner

mmp commented Feb 12, 2025

That's a reasonable theory. You might try extending the edges of the wall further out to see if that makes a difference. In general, light leaks are not usually a problem with path tracers. See this to learn more: https://www.pbr-book.org/4ed/Shapes/Managing_Rounding_Error.

@gladiator-hy
Copy link
Author

Thank you for your reply. I'll study it carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants