Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Routing Libraries List example contains deprecated button prop #43040

Closed
Joee94 opened this issue Jul 23, 2024 · 2 comments · Fixed by #43110
Closed

[docs][material-ui] Routing Libraries List example contains deprecated button prop #43040

Joee94 opened this issue Jul 23, 2024 · 2 comments · Fixed by #43110
Labels
component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. package: material-ui Specific to @mui/material support: docs-feedback Feedback from documentation page

Comments

@Joee94
Copy link

Joee94 commented Jul 23, 2024

Related page

https://mui.com/material-ui/integrations/routing/#list

Kind of issue

Other

Issue description

The example uses the <ListItem> component with the button prop which is now deprecated. A new example is needed using the <ListItemButton>.

Context

I'm trying to use a ListItemButton as a link to a new route with react-router-library.

<ListItemButton
        disabled={disabled}
        component={Link}
        to={url}
      >
        <ListItemIcon>{icon}</ListItemIcon>
        <ListItemText primary={label} />
</ListItemButton>

But this is currently not in the docs.

Search keywords: Routing Libraries List example button prop

@Joee94 Joee94 added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Jul 23, 2024
@Joee94 Joee94 closed this as completed Jul 23, 2024
@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 23, 2024
@Joee94
Copy link
Author

Joee94 commented Jul 23, 2024

Turns out it was working, I think the url being an optional prop was breaking the types.
The docs do still need updating though, have updated the description to reflect this.

@Joee94 Joee94 reopened this Jul 23, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Routing Libraries List example contains deprecated button prop [docs][material-ui] Routing Libraries List example contains deprecated button prop Jul 29, 2024
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. component: list This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jul 29, 2024
@aliharis99
Copy link
Contributor

Hi - would it be alright if I pick this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. package: material-ui Specific to @mui/material support: docs-feedback Feedback from documentation page
Projects
None yet
3 participants