feat(iroh): move iroh-net-report back into iroh

[ramfox]

Description

Move iroh-net-report back into iroh

Only the follow are made public from the old iroh-net-report (now iroh::net_report):

• iroh::net_report::Metrics
• iroh::net_report::Options
• iroh::net_report::Addr
• iroh::net_report::Client
• iroh::net_report::Report
• iroh::net_report::bind_local_stun_addr
• iroh::net_report::RelayLatencies
• iroh::net_report::QuicConfig

Breaking Changes

Technically not a breaking change to iroh since we are "adding" to the API, but we will no longer be publishing iroh-net-report to crates.io, and to use the content from iroh-net-report you would need to depend on iroh and import it using iroh::net_report.

This should only effect iroh-doctor

Notes & open questions

Would be nice to make this private, if we can adjust iroh-doctor accordingly.

For the next release, I'll make a branch that has the old iroh-net-report, adds the deprecation status to the readme/cargo.toml & publishes.

Change checklist

• Self-review.
• Documentation updates following the style guide, if relevant.
• Tests if relevant.
• All breaking changes documented.

[github-actions]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3251/docs/iroh/

Last updated: 2025-04-03T23:16:45Z

[github-actions]

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: b96cc95

[flub]

I think this is fine, but I'd like to not expose this as a public API. I can't remember if we discussed a mechanism before so that doctor can still use it, I think we did? I think it was by means of a cargo feature? But I'm not sure.

[flub]

It'd be nice to hide this behind a unstable_api cargo feature (or whatever bikeshed colour you like)? Apparently @dignifiedquire had opinions on something like this in the past though, I don't know if favour or against such constructs. Or maybe keep it entirely internal, as the API for doctor will probably become something else now according to the discussion on discourse?

[dignifiedquire]

lets merge this as is, and get the API reduction surface before the next release in as well would be my suggestion

[ramfox]

After our planning meeting, we decided I'm going to reduce the API surface to just what is necessary for doctor and get this merged by Friday.