Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslintOption "fix" not working #3

Closed
owenjs opened this issue Nov 4, 2021 · 4 comments
Closed

eslintOption "fix" not working #3

owenjs opened this issue Nov 4, 2021 · 4 comments

Comments

@owenjs
Copy link

owenjs commented Nov 4, 2021

Hey, big fan of this plugin not stopping the HMR features!

Although I am trying to use the "fix" option for eslint and it's not fixing the fixable errors on saving a source file.

plugins: [
    react(),
    eslintPlugin({
      eslintOptions: {
         fix: true
      }
    })
  ],

Want to double check that this is possible before I supply some more source code.

Thank you.

@ArnaudBarre
Copy link
Contributor

Thanks for reporting! This is fixed in 1.3.3 🎉

@owenjs
Copy link
Author

owenjs commented Nov 5, 2021

Hi, thanks for the quick fix!

Unfortunately this was still not working for me and after debugging through your code I found the issue.

report.output can be defined even when there are now messages to display.

When this is the case the function is returned too early here.

@ArnaudBarre
Copy link
Contributor

In my test, there was a warning and a fix so I didn't notice it. Thanks for pointing out, it's fixed it in 1.3.4.

@owenjs
Copy link
Author

owenjs commented Nov 5, 2021

amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants