Skip to content

Make the Lua struct an opaque #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
natecraddock opened this issue Jan 18, 2024 · 1 comment · Fixed by #73
Closed

Make the Lua struct an opaque #50

natecraddock opened this issue Jan 18, 2024 · 1 comment · Fixed by #73

Comments

@natecraddock
Copy link
Owner

Follow up from #40

This will remove the state field from the Lua struct and make the type an opaque. This makes the code simpler and shows the intent of the Lua struct more clearly.

@natecraddock
Copy link
Owner Author

Just tried this. In some areas the code is more readable. In others, less so.

No impact on the output binary, seems like llvm can optimize the code the same regardless.

I will keep the changes in a branch and reevaluate at a later time

@natecraddock natecraddock linked a pull request Mar 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant