Skip to content

Commit ce4efdc

Browse files
committed
build: fix aarch64 kits #1927
Using advice from pypa/cibuildwheel#2257
1 parent a1f3192 commit ce4efdc

File tree

3 files changed

+24
-19
lines changed

3 files changed

+24
-19
lines changed

.github/workflows/kit.yml

+12-16
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ defaults:
3737

3838
env:
3939
PIP_DISABLE_PIP_VERSION_CHECK: 1
40+
# PYVERSIONS: changing the list of versions will change the number of
41+
# expected distributions.
42+
EXPECTED: 63
4043

4144
permissions:
4245
contents: read
@@ -99,6 +102,9 @@ jobs:
99102
# }
100103
# if the_os == "macos":
101104
# them["os-version"] = "13"
105+
# if the_arch == "aarch64":
106+
# # https://github.com/pypa/cibuildwheel/issues/2257
107+
# them["os-version"] = "22.04-arm"
102108
# print(f"- {json.dumps(them)}")
103109
# ]]]
104110
- {"os": "ubuntu", "py": "cp39", "arch": "x86_64"}
@@ -111,11 +117,11 @@ jobs:
111117
- {"os": "ubuntu", "py": "cp311", "arch": "i686"}
112118
- {"os": "ubuntu", "py": "cp312", "arch": "i686"}
113119
- {"os": "ubuntu", "py": "cp313", "arch": "i686"}
114-
- {"os": "ubuntu", "py": "cp39", "arch": "aarch64"}
115-
- {"os": "ubuntu", "py": "cp310", "arch": "aarch64"}
116-
- {"os": "ubuntu", "py": "cp311", "arch": "aarch64"}
117-
- {"os": "ubuntu", "py": "cp312", "arch": "aarch64"}
118-
- {"os": "ubuntu", "py": "cp313", "arch": "aarch64"}
120+
- {"os": "ubuntu", "py": "cp39", "arch": "aarch64", "os-version": "22.04-arm"}
121+
- {"os": "ubuntu", "py": "cp310", "arch": "aarch64", "os-version": "22.04-arm"}
122+
- {"os": "ubuntu", "py": "cp311", "arch": "aarch64", "os-version": "22.04-arm"}
123+
- {"os": "ubuntu", "py": "cp312", "arch": "aarch64", "os-version": "22.04-arm"}
124+
- {"os": "ubuntu", "py": "cp313", "arch": "aarch64", "os-version": "22.04-arm"}
119125
- {"os": "macos", "py": "cp39", "arch": "arm64", "os-version": "13"}
120126
- {"os": "macos", "py": "cp310", "arch": "arm64", "os-version": "13"}
121127
- {"os": "macos", "py": "cp311", "arch": "arm64", "os-version": "13"}
@@ -136,16 +142,10 @@ jobs:
136142
- {"os": "windows", "py": "cp311", "arch": "AMD64"}
137143
- {"os": "windows", "py": "cp312", "arch": "AMD64"}
138144
- {"os": "windows", "py": "cp313", "arch": "AMD64"}
139-
# [[[end]]] (checksum: 38b83d67f00c838e5e7f69f803b7536c)
145+
# [[[end]]] (checksum: 7c3758a4ca41df53d7ebcad68f12d0d0)
140146
fail-fast: false
141147

142148
steps:
143-
- name: "Setup QEMU"
144-
if: matrix.os == 'ubuntu'
145-
uses: docker/setup-qemu-action@4574d27a4764455b42196d70a065bc6853246a25 # v3.4.0
146-
with:
147-
platforms: arm64
148-
149149
- name: "Check out the repo"
150150
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
151151
with:
@@ -292,10 +292,6 @@ jobs:
292292
merge-multiple: true
293293

294294
- name: "List distributions"
295-
env:
296-
# PYVERSIONS: changing the list of versions will change the number of
297-
# expected distributions.
298-
EXPECTED: 63
299295
run: |
300296
ls -alR
301297
echo "Number of dists, there should be $EXPECTED:"

.github/workflows/publish.yml

+9-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ defaults:
1414
run:
1515
shell: bash
1616

17+
env:
18+
# PYVERSIONS: changing the list of versions will change the number of
19+
# expected distributions.
20+
EXPECTED: 63
21+
1722
permissions:
1823
contents: read
1924

@@ -71,8 +76,9 @@ jobs:
7176
- name: "What did we get?"
7277
run: |
7378
ls -alR
74-
echo "Number of dists, should be 72:"
79+
echo "Number of dists, should be $EXPECTED:"
7580
ls -1 dist | wc -l
81+
files=$(ls dist 2>/dev/null | wc -l) && [ "$files" -eq $EXPECTED ] || exit 1
7682
7783
- name: "Generate attestations"
7884
uses: actions/attest-build-provenance@520d128f165991a6c774bcb264f323e3d70747f4 # v2.2.0
@@ -110,8 +116,9 @@ jobs:
110116
- name: "What did we get?"
111117
run: |
112118
ls -alR
113-
echo "Number of dists, should be 72:"
119+
echo "Number of dists, should be $EXPECTED:"
114120
ls -1 dist | wc -l
121+
files=$(ls dist 2>/dev/null | wc -l) && [ "$files" -eq $EXPECTED ] || exit 1
115122
116123
- name: "Generate attestations"
117124
uses: actions/attest-build-provenance@520d128f165991a6c774bcb264f323e3d70747f4 # v2.2.0

CHANGES.rst

+3-1
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ upgrading your version of coverage.py.
2323
Unreleased
2424
----------
2525

26-
Nothing yet.
26+
- Fix: some aarch64 distributions were missing (`issue 1927`_). These are now
27+
building reliably.
2728

29+
.. _issue 1927: https://github.com/nedbat/coveragepy/issues/1927
2830

2931
.. start-releases
3032

0 commit comments

Comments
 (0)