fix: disallow empty key #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eduardoboucas
approved these changes
Jan 11, 2024
| @@ -307,6 +307,10 @@ export class Store { | |||
| } | |||
|
|
|||
| private static validateKey(key: string) { | |||
| if (key === '') { | |||
| throw new Error('Blob key must not be empty.') | |||
There was a problem hiding this comment.
You could also make this part of the check on line 318 and adjust the message to something like:
Blob key must be a sequence of Unicode characters whose UTF-8 encoding is between 1 and 600 bytes long.
Just an idea, no strong preference.
There was a problem hiding this comment.
That's nifty - but if I were debugging this exception, I think i'd be way more confused by the words "Unicode" and "UTF-8" than necessary. Gonna keep it like it is!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallows
""as key. This is not a breaking change, because before we had a bug whereget("")would show the result oflist()- so this didn't work in the first place.Resolves https://linear.app/netlify/issue/COM-283/blobs-get-shows-unintended-api-response.