Skip to content

feat!: remove fresh property from metadata result #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Removes the fresh property from the output of getWithMetadata() since it's redundant. To know whether a cached entry is fresh or stale, users can compare the value of the etag property they send with the etag property we return.

@eduardoboucas eduardoboucas requested a review from a team as a code owner November 9, 2023 13:59
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit d01c589
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/654ce5dbf96c8c00081847f6
😎 Deploy Preview https://deploy-preview-99--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 9, 2023
Copy link

@minivan minivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆕 🆒 🍬

@eduardoboucas eduardoboucas merged commit a0f337a into main Nov 9, 2023
@eduardoboucas eduardoboucas deleted the feat/remove-fresh branch November 9, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants