Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Installers don't install headers #2149

Closed
kkaefer opened this issue Nov 19, 2011 · 7 comments
Closed

Installers don't install headers #2149

kkaefer opened this issue Nov 19, 2011 · 7 comments

Comments

@kkaefer
Copy link

kkaefer commented Nov 19, 2011

This makes it impossible to compile third party add-ons, e.g. with npm.

See TryGhost/node-sqlite3#50

@bnoordhuis
Copy link
Member

@igorzi @piscisaureus: I'll fix the pkg, can one of you fix the msi?

@igorzi
Copy link

igorzi commented Nov 21, 2011

should this wait until #2136?

@ry
Copy link

ry commented Nov 21, 2011

This is a questionable feature. People who want to build addons can build from source. Instead we need to accelerate the npm-binary install process.

@defunctzombie
Copy link

C++ addons are not uncommon for node. Without those headers you can't build the addons for a deployed version of node. Does installing the headers really slow down the install process enough to warrant not having them?

@arturadib
Copy link

Does installing the headers really slow down the install process enough to warrant not having them?

Yeah I guess that's the question. It's not fun asking folks to download and compile node just so that they can npm-install certain addons. On the other hand, if that hampers the binary install process, that's definitely a tradeoff to consider.

@donpark
Copy link

donpark commented Nov 30, 2011

Hmm. How about packing the headers as an NPM package so that any NPM package that needs them can add them as dependency? To do this proper, NPM should IMO breakout dependency by type: build-time, runtime, and environmental dependencies.

@isaacs
Copy link

isaacs commented Apr 13, 2012

This is fixed by using node-gyp to build stuff.

@isaacs isaacs closed this as completed Apr 13, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants