-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Installers don't install headers #2149
Comments
@igorzi @piscisaureus: I'll fix the pkg, can one of you fix the msi? |
should this wait until #2136? |
This is a questionable feature. People who want to build addons can build from source. Instead we need to accelerate the npm-binary install process. |
C++ addons are not uncommon for node. Without those headers you can't build the addons for a deployed version of node. Does installing the headers really slow down the install process enough to warrant not having them? |
Yeah I guess that's the question. It's not fun asking folks to download and compile node just so that they can npm-install certain addons. On the other hand, if that hampers the binary install process, that's definitely a tradeoff to consider. |
Hmm. How about packing the headers as an NPM package so that any NPM package that needs them can add them as dependency? To do this proper, NPM should IMO breakout dependency by type: build-time, runtime, and environmental dependencies. |
This is fixed by using node-gyp to build stuff. |
This makes it impossible to compile third party add-ons, e.g. with npm.
See TryGhost/node-sqlite3#50
The text was updated successfully, but these errors were encountered: