Build broken on Windows (VS2019)

[targos]

https://ci.nodejs.org/job/node-compile-windows/30296/nodes=win-vs2019-x86/console

10:57:55 mksnapshot.obj : error LNK2019: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Object> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Handle@VObject@internal@v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) referenced in function "public: static bool __cdecl v8::internal::HashTable<class v8::internal::EphemeronHashTable,class v8::internal::EphemeronHashTableShape>::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$HashTable@VEphemeronHashTable@internal@v8@@VEphemeronHashTableShape@23@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
10:57:55 snapshot-empty.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Object> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Handle@VObject@internal@v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
10:57:55 mksnapshot.obj : error LNK2019: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Name> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Handle@VName@internal@v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) referenced in function "public: static bool __cdecl v8::internal::HashTable<class v8::internal::NameDictionary,class v8::internal::NameDictionaryShape>::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$HashTable@VNameDictionary@internal@v8@@VNameDictionaryShape@23@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
10:57:55 snapshot-empty.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Name> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Handle@VName@internal@v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
10:57:55 mksnapshot.obj : error LNK2019: unresolved external symbol "public: static bool __cdecl v8::internal::GlobalDictionaryShape::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@GlobalDictionaryShape@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) referenced in function "public: static bool __cdecl v8::internal::HashTable<class v8::internal::GlobalDictionary,class v8::internal::GlobalDictionaryShape>::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$HashTable@VGlobalDictionary@internal@v8@@VGlobalDictionaryShape@23@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
10:57:55 snapshot-empty.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::GlobalDictionaryShape::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@GlobalDictionaryShape@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
10:57:55 ..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 3 unresolved externals [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]

[targos]

/cc @nodejs/platform-windows

[gengjiawen]

Also you can see the error from github action.

Log from: https://github.com/nodejs/node-v8/runs/388526007

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2857,5): error MSB4018: The "AssignTargetPath" task failed unexpectedly. [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_initializers.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2857,5): error MSB4018: System.ArgumentException: Illegal characters in path. [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_initializers.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2857,5): error MSB4018:    at System.IO.Path.CheckInvalidPathChars(String path, Boolean checkAdditional) [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_initializers.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2857,5): error MSB4018:    at System.IO.Path.IsPathRooted(String path) [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_initializers.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2857,5): error MSB4018:    at Microsoft.Build.Tasks.AssignTargetPath.Execute() [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_initializers.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2857,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_initializers.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2857,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_initializers.vcxproj]

[gengjiawen]

Looks like path generated not right (target v8-initializer).
Compatibility issue with node-gyp ? cc @nodejs/node-gyp

[richardlau]

node-gyp isn't used to build Node.js. It's possible there's an issue with gyp but it's not failing on the current master.

[gengjiawen]

Which part in gyp handles include directive, looks like a path format problem.

[richardlau]

Aren't those #include directives written out by torque?

[gengjiawen]

Looks like not the root cause, Node.js master branch with same path.

[gengjiawen]

Another possible cause (right panel is current repo) :

[gengjiawen]

If we remove the $quote in Include value , another build issue will occur

     Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
platform-embedded-file-writer-win.obj : error LNK2019: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Object> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$H
andle@VObject@internal@v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) referenced in function "public: static bool __cdecl v8::internal::HashTable<class v8::internal::EphemeronHashTable,class v8::internal::EphemeronHashTableShape>::IsKey(class v8::internal::ReadOnl
yRoots,class v8::internal::Object)" (?IsKey@?$HashTable@VEphemeronHashTable@internal@v8@@VEphemeronHashTableShape@23@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\projects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
mksnapshot.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Object> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Handle@VObject@internal@
v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\projects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
snapshot-empty.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Object> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Handle@VObject@inter
nal@v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\projects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-win.obj : error LNK2019: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Name> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Han
dle@VName@internal@v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) referenced in function "public: static bool __cdecl v8::internal::HashTable<class v8::internal::NameDictionary,class v8::internal::NameDictionaryShape>::IsKey(class v8::internal::ReadOnlyRoots,class
 v8::internal::Object)" (?IsKey@?$HashTable@VNameDictionary@internal@v8@@VNameDictionaryShape@23@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\projects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
mksnapshot.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Name> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Handle@VName@internal@v8@@
@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\projects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
snapshot-empty.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::BaseShape<class v8::internal::Handle<class v8::internal::Name> >::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$BaseShape@V?$Handle@VName@internal@
v8@@@internal@v8@@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\projects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-win.obj : error LNK2019: unresolved external symbol "public: static bool __cdecl v8::internal::GlobalDictionaryShape::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@GlobalDictionaryShape@internal@v8@@SA_NVReadOnlyRoots@23@VObj
ect@23@@Z) referenced in function "public: static bool __cdecl v8::internal::HashTable<class v8::internal::GlobalDictionary,class v8::internal::GlobalDictionaryShape>::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@?$HashTable@VGlobalDictionary@internal@v8
@@VGlobalDictionaryShape@23@@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\projects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
mksnapshot.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::GlobalDictionaryShape::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@GlobalDictionaryShape@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\projects
\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
snapshot-empty.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl v8::internal::GlobalDictionaryShape::IsKey(class v8::internal::ReadOnlyRoots,class v8::internal::Object)" (?IsKey@GlobalDictionaryShape@internal@v8@@SA_NVReadOnlyRoots@23@VObject@23@@Z) [C:\proj
ects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]
..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 3 unresolved externals [C:\projects\appveyor-playground\node-v8\tools\v8_gypfiles\mksnapshot.vcxproj]

[targos]

I can probably handle the unresolved symbols. I did that in the past (it's about inline methods that should be moved from .h to -inl.h)
Now we need to find out what put those quotes and how to prevent that.

[targos]

Thanks @gengjiawen for your help on this

[richardlau]

Another possible cause (right panel is current repo) :

I think there should at least be a space between ..\..\deps\v8\src\torque\runtime-support.h and ". @targos Looks like there's a missing comma at the end of this line

node-v8/tools/v8_gypfiles/v8.gyp

Line 284 in be1fee9

'<(V8_ROOT)/src/torque/runtime-support.h'

[richardlau]

Let's see if fixing the missing comma gets the build further along: #136

[richardlau]

Looks like it fixed the quote issue and gets to the same unresolved symbols.

[targos]

Building on my computer to fix the unresolved symbols.

[targos]

Well, I cannot reproduce the errors on my PC (VS 2019). Node builds fine now...

[targos]

Actually, VS2019 is fixed 🎉

https://ci.nodejs.org/job/node-compile-windows/31309/