Skip to content

Commit 5c855a7

Browse files
committed
src: make req_wrap a unique_ptr in AfterConnect
PR-URL: #23115 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 7ac109d commit 5c855a7

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/connection_wrap.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ void ConnectionWrap<WrapType, UVType>::OnConnection(uv_stream_t* handle,
7777
template <typename WrapType, typename UVType>
7878
void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req,
7979
int status) {
80-
ConnectWrap* req_wrap = static_cast<ConnectWrap*>(req->data);
80+
std::unique_ptr<ConnectWrap> req_wrap
81+
(static_cast<ConnectWrap*>(req->data));
8182
CHECK_NOT_NULL(req_wrap);
8283
WrapType* wrap = static_cast<WrapType*>(req->handle->data);
8384
CHECK_EQ(req_wrap->env(), wrap->env());
@@ -108,8 +109,6 @@ void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req,
108109
};
109110

110111
req_wrap->MakeCallback(env->oncomplete_string(), arraysize(argv), argv);
111-
112-
delete req_wrap;
113112
}
114113

115114
template ConnectionWrap<PipeWrap, uv_pipe_t>::ConnectionWrap(

0 commit comments

Comments
 (0)