Skip to content

Number property causes exception in RetrievePagePropertyItem #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Scantheus opened this issue Aug 22, 2022 · 5 comments
Closed

Number property causes exception in RetrievePagePropertyItem #309

Scantheus opened this issue Aug 22, 2022 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Scantheus
Copy link

I was trying to work ahead to support v4.0.0 and RetrievePagePropertyItem and noticed it was already in v3.1.0 but got this error when trying to retrieve a number property on a simple 5 property database. Title, Date, Select, and RichText type properties work fine.

Newtonsoft.Json.JsonSerializationException
Error converting value 6043 to type 'Notion.Client.Number'. Path 'number', line 1, position 71.
Source=Newtonsoft.Json
Inner Exception 1:
ArgumentException: Could not cast or convert from System.Int64 to Notion.Client.Number.

@KoditkarVedant
Copy link
Contributor

@Scantheus you trying library and reporting these bugs. If you are open you can also open the pull request and I'm happy to accept it. I mostly try to work on weekends on this library. Any help would be appreciated.

@KoditkarVedant KoditkarVedant added the bug Something isn't working label Aug 23, 2022
@KoditkarVedant KoditkarVedant self-assigned this Aug 28, 2022
@KoditkarVedant KoditkarVedant added this to the 4.0.0 milestone Aug 28, 2022
@KoditkarVedant
Copy link
Contributor

Available as part of pre-release 4.0.0-preview-2.8.29.2022

@Scantheus
Copy link
Author

This is fixed in preview.

@Scantheus
Copy link
Author

@KoditkarVedant Sorry, The API is outside of my level of expertise. I'm a desktop developer with very little web API experience. I'm good for testing and sometimes pointing you where I think the issue is but, otherwise, I'm not helpful as a code contributor.

@KoditkarVedant
Copy link
Contributor

4.0.0 Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants