Skip to content

BlockId is getting sent in Append Children api request #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KoditkarVedant opened this issue Oct 14, 2023 · 1 comment · Fixed by #399
Closed

BlockId is getting sent in Append Children api request #398

KoditkarVedant opened this issue Oct 14, 2023 · 1 comment · Fixed by #399
Labels
bug Something isn't working

Comments

@KoditkarVedant
Copy link
Contributor

Recently we merged the path and body parameters in BlockAppendChildrenRequest class but this introduced a problem when we send the request by type casting it to IBlockAppendChildrenBodyParameters and expect it would exclude the BlockId from serialization but that is not the case and the BlockId is getting passed as the body.
@KoditkarVedant KoditkarVedant added the bug Something isn't working label Oct 14, 2023
@KoditkarVedant
Copy link
Contributor Author

The issue is introduce by #395

@KoditkarVedant KoditkarVedant mentioned this issue Oct 14, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add wrapper class to avoid sending block id as part of request body notion-dotnet/notion-sdk-net
1 participant
@KoditkarVedant