Skip to content

Bookmark filter should include parent directory #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
remvn opened this issue Mar 12, 2024 · 1 comment · Fixed by #2704
Closed

Bookmark filter should include parent directory #2703

remvn opened this issue Mar 12, 2024 · 1 comment · Fixed by #2704
Labels
bug Something isn't working

Comments

@remvn
Copy link
Contributor

remvn commented Mar 12, 2024

Description

If we bookmark a file that is inside a directory, the bookmark filter should include the parent directory of that file

Example:

  1. File bookmark_me.md are being marked
    image

  2. Toggle bookmark filter with M
    image

Neovim version

NVIM v0.9.4
Build type: Release
LuaJIT 2.1.1692716794

Operating system and version

Linux 5.15.146.1-microsoft-standard-WSL2

Windows variant

WSL

nvim-tree version

041dbd1

Clean room replication

Don't need to change anything

Steps to reproduce

Use latest commit, bookmark some file inside a directory then toggle bookmark filter with M

Expected behavior

The filter should include the parent directory of files are being marked

Actual behavior

No response

@remvn remvn added the bug Something isn't working label Mar 12, 2024
@remvn
Copy link
Contributor Author

remvn commented Mar 12, 2024

My PR should fix this issue, if you have any edge case, please let me know

Before filter:
image

After filter:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant