Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node/rpc): RPC Server Launcher #1124

Open
refcell opened this issue Feb 26, 2025 · 0 comments · May be fixed by #1325
Open

feat(node/rpc): RPC Server Launcher #1124

refcell opened this issue Feb 26, 2025 · 0 comments · May be fixed by #1325
Assignees
Labels
A-binaries Area: binaries K-feature Kind: feature M-help-wanted Meta: Extra attention is needed

Comments

@refcell
Copy link
Collaborator

refcell commented Feb 26, 2025

Background

kona-rpc uses jsonrpsee to construct server and client JSON-RPC APIs.

In jsonrpsee, these JSON-RPC api implementations can be converted into a RpcModule. Since kona will have multiple RpcModules, modules can be merged using the merge() method.

After merging all the modules, the jsonrpsee::server::Server instance is started, passing in the modules as an argument.
Starting the server returns a ServerHandle that can be awaited on using the stopped() method.

Output

This ticket is to create a ServerLauncher that constructs the jsonrpsee::server::Server and accepts modules via a merge method. It should lastly have a start method that consumes the ServerLauncher itself, starting the server with its modules, and returns the ServerHandle.

Future tickets will tackle implementations of the JSON-RPC APIs in kona-rpc and merging them into the ServerLauncher.

@refcell refcell added the A-binaries Area: binaries label Feb 26, 2025
@refcell refcell added M-help-wanted Meta: Extra attention is needed K-feature Kind: feature labels Feb 26, 2025
@refcell refcell changed the title feat(node/rpc): Setup RPC Server feat(node/rpc): RPC Server Setup Mar 27, 2025
@refcell refcell changed the title feat(node/rpc): RPC Server Setup feat(node/rpc): RPC Server Launcher Mar 27, 2025
@refcell refcell linked a pull request Mar 27, 2025 that will close this issue
@refcell refcell self-assigned this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-binaries Area: binaries K-feature Kind: feature M-help-wanted Meta: Extra attention is needed
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant