Skip to content

Commit b6d3096

Browse files
anshulgarg31dtor
authored andcommitted
Input: uinput - switch to using for_each_set_bit()
Use for_each_set_bit to check for set bits in bitmap as it is more efficient and compact. Signed-off-by: Anshul Garg <aksgarg1989@gmail.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 948cea1 commit b6d3096

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/input/misc/uinput.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,8 @@ static int uinput_validate_absbits(struct input_dev *dev)
320320
* Check if absmin/absmax/absfuzz/absflat are sane.
321321
*/
322322

323-
for (cnt = 0; cnt < ABS_CNT; cnt++) {
323+
for_each_set_bit(cnt, dev->absbit, ABS_CNT) {
324324
int min, max;
325-
if (!test_bit(cnt, dev->absbit))
326-
continue;
327325

328326
min = input_abs_get_min(dev, cnt);
329327
max = input_abs_get_max(dev, cnt);
@@ -416,7 +414,7 @@ static int uinput_setup_device(struct uinput_device *udev,
416414
dev->id.product = user_dev->id.product;
417415
dev->id.version = user_dev->id.version;
418416

419-
for (i = 0; i < ABS_CNT; i++) {
417+
for_each_set_bit(i, dev->absbit, ABS_CNT) {
420418
input_abs_set_max(dev, i, user_dev->absmax[i]);
421419
input_abs_set_min(dev, i, user_dev->absmin[i]);
422420
input_abs_set_fuzz(dev, i, user_dev->absfuzz[i]);

0 commit comments

Comments
 (0)