Skip to content

Commit 19424bc

Browse files
redhatHameedtchughesiv
redhatHameed
and
tchughesiv
authored
feat: Feast Operator support log level configuration for services (feast-dev#4808)
* fix: Feast Operator updated the kustomize version to v5.5.0 Signed-off-by: Abdul Hameed <ahameed@redhat.com> * feat : Feast Operator support log level configuration for services Signed-off-by: Abdul Hameed <ahameed@redhat.com> * Update infra/feast-operator/internal/controller/services/services.go Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com> Signed-off-by: Abdul Hameed <ahameed@redhat.com> * Update infra/feast-operator/internal/controller/services/services.go Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com> Signed-off-by: Abdul Hameed <ahameed@redhat.com> * added unit test for loglevel Signed-off-by: Abdul Hameed <ahameed@redhat.com> * fix the loglevel command Signed-off-by: Abdul Hameed <ahameed@redhat.com> * moved the logLevel under LocalRegistryConfig and updated testcase to validate it Signed-off-by: Abdul Hameed <ahameed@redhat.com> --------- Signed-off-by: Abdul Hameed <ahameed@redhat.com> Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com>
1 parent 3649554 commit 19424bc

File tree

7 files changed

+460
-9
lines changed

7 files changed

+460
-9
lines changed

‎infra/feast-operator/api/v1alpha1/featurestore_types.go

+12
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,10 @@ type OfflineStore struct {
7777
ServiceConfigs `json:",inline"`
7878
Persistence *OfflineStorePersistence `json:"persistence,omitempty"`
7979
TLS *OfflineTlsConfigs `json:"tls,omitempty"`
80+
// LogLevel sets the logging level for the offline store service
81+
// Allowed values: "debug", "info", "warning", "error", "critical".
82+
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
83+
LogLevel string `json:"logLevel,omitempty"`
8084
}
8185

8286
// OfflineTlsConfigs configures server TLS for the offline feast service. in an openshift cluster, this is configured by default using service serving certificates.
@@ -130,6 +134,10 @@ type OnlineStore struct {
130134
ServiceConfigs `json:",inline"`
131135
Persistence *OnlineStorePersistence `json:"persistence,omitempty"`
132136
TLS *TlsConfigs `json:"tls,omitempty"`
137+
// LogLevel sets the logging level for the online store service
138+
// Allowed values: "debug", "info", "warning", "error", "critical".
139+
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
140+
LogLevel string `json:"logLevel,omitempty"`
133141
}
134142

135143
// OnlineStorePersistence configures the persistence settings for the online store service
@@ -177,6 +185,10 @@ type LocalRegistryConfig struct {
177185
ServiceConfigs `json:",inline"`
178186
Persistence *RegistryPersistence `json:"persistence,omitempty"`
179187
TLS *TlsConfigs `json:"tls,omitempty"`
188+
// LogLevel sets the logging level for the registry service
189+
// Allowed values: "debug", "info", "warning", "error", "critical".
190+
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
191+
LogLevel string `json:"logLevel,omitempty"`
180192
}
181193

182194
// RegistryPersistence configures the persistence settings for the registry service

‎infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml

+66
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,17 @@ spec:
227227
description: PullPolicy describes a policy for if/when to
228228
pull a container image
229229
type: string
230+
logLevel:
231+
description: |-
232+
LogLevel sets the logging level for the offline store service
233+
Allowed values: "debug", "info", "warning", "error", "critical".
234+
enum:
235+
- debug
236+
- info
237+
- warning
238+
- error
239+
- critical
240+
type: string
230241
persistence:
231242
description: OfflineStorePersistence configures the persistence
232243
settings for the offline store service
@@ -576,6 +587,17 @@ spec:
576587
description: PullPolicy describes a policy for if/when to
577588
pull a container image
578589
type: string
590+
logLevel:
591+
description: |-
592+
LogLevel sets the logging level for the online store service
593+
Allowed values: "debug", "info", "warning", "error", "critical".
594+
enum:
595+
- debug
596+
- info
597+
- warning
598+
- error
599+
- critical
600+
type: string
579601
persistence:
580602
description: OnlineStorePersistence configures the persistence
581603
settings for the online store service
@@ -939,6 +961,17 @@ spec:
939961
description: PullPolicy describes a policy for if/when
940962
to pull a container image
941963
type: string
964+
logLevel:
965+
description: |-
966+
LogLevel sets the logging level for the registry service
967+
Allowed values: "debug", "info", "warning", "error", "critical".
968+
enum:
969+
- debug
970+
- info
971+
- warning
972+
- error
973+
- critical
974+
type: string
942975
persistence:
943976
description: RegistryPersistence configures the persistence
944977
settings for the registry service
@@ -1429,6 +1462,17 @@ spec:
14291462
description: PullPolicy describes a policy for if/when
14301463
to pull a container image
14311464
type: string
1465+
logLevel:
1466+
description: |-
1467+
LogLevel sets the logging level for the offline store service
1468+
Allowed values: "debug", "info", "warning", "error", "critical".
1469+
enum:
1470+
- debug
1471+
- info
1472+
- warning
1473+
- error
1474+
- critical
1475+
type: string
14321476
persistence:
14331477
description: OfflineStorePersistence configures the persistence
14341478
settings for the offline store service
@@ -1784,6 +1828,17 @@ spec:
17841828
description: PullPolicy describes a policy for if/when
17851829
to pull a container image
17861830
type: string
1831+
logLevel:
1832+
description: |-
1833+
LogLevel sets the logging level for the online store service
1834+
Allowed values: "debug", "info", "warning", "error", "critical".
1835+
enum:
1836+
- debug
1837+
- info
1838+
- warning
1839+
- error
1840+
- critical
1841+
type: string
17871842
persistence:
17881843
description: OnlineStorePersistence configures the persistence
17891844
settings for the online store service
@@ -2155,6 +2210,17 @@ spec:
21552210
description: PullPolicy describes a policy for if/when
21562211
to pull a container image
21572212
type: string
2213+
logLevel:
2214+
description: |-
2215+
LogLevel sets the logging level for the registry service
2216+
Allowed values: "debug", "info", "warning", "error", "critical".
2217+
enum:
2218+
- debug
2219+
- info
2220+
- warning
2221+
- error
2222+
- critical
2223+
type: string
21582224
persistence:
21592225
description: RegistryPersistence configures the persistence
21602226
settings for the registry service

‎infra/feast-operator/config/samples/v1alpha1_featurestore_services_loglevel.yaml

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
apiVersion: feast.dev/v1alpha1
2+
kind: FeatureStore
3+
metadata:
4+
name: sample-services-loglevel
5+
spec:
6+
feastProject: my_project
7+
services:
8+
onlineStore:
9+
logLevel: debug
10+
offlineStore:
11+
logLevel: debug
12+
registry:
13+
local:
14+
logLevel: info
15+

‎infra/feast-operator/dist/install.yaml

+67-1
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,17 @@ spec:
235235
description: PullPolicy describes a policy for if/when to
236236
pull a container image
237237
type: string
238+
logLevel:
239+
description: |-
240+
LogLevel sets the logging level for the offline store service
241+
Allowed values: "debug", "info", "warning", "error", "critical".
242+
enum:
243+
- debug
244+
- info
245+
- warning
246+
- error
247+
- critical
248+
type: string
238249
persistence:
239250
description: OfflineStorePersistence configures the persistence
240251
settings for the offline store service
@@ -584,6 +595,17 @@ spec:
584595
description: PullPolicy describes a policy for if/when to
585596
pull a container image
586597
type: string
598+
logLevel:
599+
description: |-
600+
LogLevel sets the logging level for the online store service
601+
Allowed values: "debug", "info", "warning", "error", "critical".
602+
enum:
603+
- debug
604+
- info
605+
- warning
606+
- error
607+
- critical
608+
type: string
587609
persistence:
588610
description: OnlineStorePersistence configures the persistence
589611
settings for the online store service
@@ -947,6 +969,17 @@ spec:
947969
description: PullPolicy describes a policy for if/when
948970
to pull a container image
949971
type: string
972+
logLevel:
973+
description: |-
974+
LogLevel sets the logging level for the registry service
975+
Allowed values: "debug", "info", "warning", "error", "critical".
976+
enum:
977+
- debug
978+
- info
979+
- warning
980+
- error
981+
- critical
982+
type: string
950983
persistence:
951984
description: RegistryPersistence configures the persistence
952985
settings for the registry service
@@ -1437,6 +1470,17 @@ spec:
14371470
description: PullPolicy describes a policy for if/when
14381471
to pull a container image
14391472
type: string
1473+
logLevel:
1474+
description: |-
1475+
LogLevel sets the logging level for the offline store service
1476+
Allowed values: "debug", "info", "warning", "error", "critical".
1477+
enum:
1478+
- debug
1479+
- info
1480+
- warning
1481+
- error
1482+
- critical
1483+
type: string
14401484
persistence:
14411485
description: OfflineStorePersistence configures the persistence
14421486
settings for the offline store service
@@ -1792,6 +1836,17 @@ spec:
17921836
description: PullPolicy describes a policy for if/when
17931837
to pull a container image
17941838
type: string
1839+
logLevel:
1840+
description: |-
1841+
LogLevel sets the logging level for the online store service
1842+
Allowed values: "debug", "info", "warning", "error", "critical".
1843+
enum:
1844+
- debug
1845+
- info
1846+
- warning
1847+
- error
1848+
- critical
1849+
type: string
17951850
persistence:
17961851
description: OnlineStorePersistence configures the persistence
17971852
settings for the online store service
@@ -2163,6 +2218,17 @@ spec:
21632218
description: PullPolicy describes a policy for if/when
21642219
to pull a container image
21652220
type: string
2221+
logLevel:
2222+
description: |-
2223+
LogLevel sets the logging level for the registry service
2224+
Allowed values: "debug", "info", "warning", "error", "critical".
2225+
enum:
2226+
- debug
2227+
- info
2228+
- warning
2229+
- error
2230+
- critical
2231+
type: string
21662232
persistence:
21672233
description: RegistryPersistence configures the persistence
21682234
settings for the registry service
@@ -2894,7 +2960,7 @@ spec:
28942960
- --leader-elect
28952961
command:
28962962
- /manager
2897-
image: feastdev/feast-operator:0.41.0
2963+
image: feastdev/feast-operator:0.42.0
28982964
livenessProbe:
28992965
httpGet:
29002966
path: /healthz

0 commit comments

Comments
 (0)