Skip to content

Commit 32aaf9a

Browse files
authored
fix: Remove unnecessary google cloud steps & upgrade docker action versions (feast-dev#4925)
remove unecessary google cloud steps & upgrade docker action versions Signed-off-by: Tommy Hughes <tohughes@redhat.com>
1 parent 13c7267 commit 32aaf9a

File tree

2 files changed

+10
-18
lines changed

2 files changed

+10
-18
lines changed

.github/workflows/java_master_only.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
- name: Build image
4242
run: make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
4343
- name: Login to Quay.io
44-
uses: docker/login-action@v1
44+
uses: docker/login-action@v3
4545
with:
4646
registry: quay.io
4747
username: ${{ secrets.QUAYIO_CI_USERNAME }}

.github/workflows/master_only.yml

+9-17
Original file line numberDiff line numberDiff line change
@@ -96,39 +96,31 @@ jobs:
9696
matrix:
9797
component: [ feature-server-dev, feature-transformation-server, feast-operator ]
9898
env:
99-
MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
10099
REGISTRY: quay.io/feastdev-ci
100+
IMAGE: ${{ matrix.component }}
101101
steps:
102102
- uses: actions/checkout@v4
103103
- name: Set up QEMU
104-
uses: docker/setup-qemu-action@v1
104+
uses: docker/setup-qemu-action@v3
105105
- name: Set up Docker Buildx
106-
uses: docker/setup-buildx-action@v2
106+
uses: docker/setup-buildx-action@v3
107107
with:
108108
install: true
109109
- name: Login to Quay.io
110-
uses: docker/login-action@v1
110+
uses: docker/login-action@v3
111111
with:
112112
registry: quay.io
113113
username: ${{ secrets.QUAYIO_CI_USERNAME }}
114114
password: ${{ secrets.QUAYIO_CI_TOKEN }}
115-
- name: Authenticate to Google Cloud
116-
uses: 'google-github-actions/auth@v1'
117-
with:
118-
credentials_json: '${{ secrets.GCP_SA_KEY }}'
119-
- name: Set up gcloud SDK
120-
uses: google-github-actions/setup-gcloud@v1
121-
with:
122-
project_id: ${{ secrets.GCP_PROJECT_ID }}
123-
- name: Use gcloud CLI
124-
run: gcloud info
125-
- run: gcloud auth configure-docker --quiet
126115
- name: Build image
127116
run: |
128117
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
129118
- name: Push image
130119
run: |
131120
make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
132121
133-
docker tag ${REGISTRY}/${{ matrix.component }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.component }}:develop
134-
docker push ${REGISTRY}/${{ matrix.component }}:develop
122+
if [[ ${{ matrix.component }} == "feature-server-dev" ]]; then
123+
echo "IMAGE=feature-server" >> $GITHUB_ENV
124+
fi
125+
docker tag ${REGISTRY}/${IMAGE}:${GITHUB_SHA} ${REGISTRY}/${IMAGE}:develop
126+
docker push ${REGISTRY}/${IMAGE}:develop

0 commit comments

Comments
 (0)