Skip to content

Commit 695e49b

Browse files
authored
fix: Fix integration build/push for images (feast-dev#4923)
fix integration build/push for images Signed-off-by: Tommy Hughes <tohughes@redhat.com>
1 parent 40b975b commit 695e49b

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

.github/workflows/java_master_only.yml

+6
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,12 @@ jobs:
4040
run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
4141
- name: Build image
4242
run: make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
43+
- name: Login to Quay.io
44+
uses: docker/login-action@v1
45+
with:
46+
registry: quay.io
47+
username: ${{ secrets.QUAYIO_CI_USERNAME }}
48+
password: ${{ secrets.QUAYIO_CI_TOKEN }}
4349
- name: Push image
4450
run: make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
4551
- name: Push development Docker image

.github/workflows/master_only.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494
runs-on: ubuntu-latest
9595
strategy:
9696
matrix:
97-
component: [ feature-server, feature-server-java, feature-transformation-server, feast-operator ]
97+
component: [ feature-server-dev, feature-transformation-server, feast-operator ]
9898
env:
9999
MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
100100
REGISTRY: quay.io/feastdev-ci

Makefile

+11-3
Original file line numberDiff line numberDiff line change
@@ -477,11 +477,11 @@ push-ci-docker:
477477
docker push $(REGISTRY)/feast-ci:$(VERSION)
478478

479479
push-feature-server-docker:
480-
docker push $(REGISTRY)/feature-server:$$VERSION
480+
docker push $(REGISTRY)/feature-server:$(VERSION)
481481

482482
build-feature-server-docker:
483-
docker buildx build --build-arg VERSION=$$VERSION \
484-
-t $(REGISTRY)/feature-server:$$VERSION \
483+
docker buildx build --build-arg VERSION=$(VERSION) \
484+
-t $(REGISTRY)/feature-server:$(VERSION) \
485485
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile --load .
486486

487487
push-feature-transformation-server-docker:
@@ -531,6 +531,14 @@ build-feature-server-dev:
531531
-t feastdev/feature-server:dev \
532532
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev --load .
533533

534+
build-feature-server-dev-docker:
535+
docker buildx build \
536+
-t $(REGISTRY)/feature-server:$(VERSION) \
537+
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev --load .
538+
539+
push-feature-server-dev-docker:
540+
docker push $(REGISTRY)/feature-server:$(VERSION)
541+
534542
build-java-docker-dev:
535543
make build-java-no-tests REVISION=dev
536544
docker buildx build --build-arg VERSION=dev \

0 commit comments

Comments
 (0)