-
Notifications
You must be signed in to change notification settings - Fork 9
bug: use specific version in hook #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting the bug. We are creating a major and minor version tag afterward on every release to support GitHub Actions. This might be causing the issue, as pre-commit takes the latest created tag on autoupdate. We'll look into it in detail. |
thank you for your amazing tools and contributions :) |
Hi @gacallea, I have updated the tags for v1.2.0 and adjusted the order to v1.2.0, v1.2, and v1. However, it seems that pre-commit prioritizes the two-digit rev over the three-digit rev during autoupdate, and it doesn't show a warning message for the two-digit rev (minor version). From my perspective, using a minor version tag rev in pre-commit is acceptable. I'll create a PR for it. |
Hi @aj3sh :) thank you so much for looking into this and for coming up with a change so quickly! One note if I may: there must be a way to use the full v1.2.0 tho, all other pre-commit hooks I have don't have the issue I reported. I suspect pre-commit is going to warn users with v.12 as well. What do you reckon? |
Taking reference from other official GitHub action tags, I have decided not to keep the two-digit tags (eg. v1.2) for GitHub actions. This immediately solves this issue. Ref tags: @gacallea, now you can use cc: @sugat009 , @golesuman , @subashcs |
amazing thanks! I confirm it already works :) |
Describe the bug
.pre-commit-config.yaml
, running the hook or autoupdate reverts it to just v1To Reproduce
pre-commit autoupdate
and see the rev changeExpected behavior
.pre-commit-config.yaml
it should stick to itEnvironment
Additional context
the relevant
.pre-commit-config.yaml
I set but runningautoupdate
reverts it to just v1:The text was updated successfully, but these errors were encountered: