zfs-mount-generator nofail option does not work

[iyzana]

System information

Type	Version/Name
Distribution Name	Arch Linux
Distribution Version	rolling
Kernel Version	6.12.18-1-lts
Architecture	x86_64
OpenZFS Version	2.3.1-1

Describe the problem you're observing

Mount units generated by zfs-mount-generator with org.openzfs.systemd:nofail=on set on the dataset still have Before=local-fs.target set in the running system.

That is because according to man 5 systemd.mount: "Mount units referring to local file systems automatically gain an After= dependency on local-fs-pre.target, and a Before= dependency on local-fs.target unless one or more mount options among nofail, x-systemd.wanted-by=, and x-systemd.required-by= is set."

The zfs-mount-generator does not itself set the Before=local-fs.target ordering when org.openzfs.systemd:nofail=on is set, but that does not keep systemd from then still adding it as a default dependency.

I believe zfs-mount-generator should also include nofail in the mount Options= in this case.

Describe how to reproduce the problem

1. Set canmount=on and org.openzfs.systemd:nofail=on on a dataset.
2. systemctl soft-reboot
3. systemctl show mnt-<dataset>.mount | grep Before=
4. Observe that local-fs.target is still included

Include any warning/errors/backtraces from the system logs