Skip to content

Commit 4539722

Browse files
arndbtorvalds
authored andcommitted
mm/filemap.c: provide dummy filemap_page_mkwrite() for NOMMU
Building orangefs on MMU-less machines now results in a link error because of the newly introduced use of the filemap_page_mkwrite() function: ERROR: "filemap_page_mkwrite" [fs/orangefs/orangefs.ko] undefined! This adds a dummy version for it, similar to the existing generic_file_mmap and generic_file_readonly_mmap stubs in the same file, to avoid the link error without adding #ifdefs in each file system that uses these. Link: http://lkml.kernel.org/r/20180409105555.2439976-1-arnd@arndb.de Fixes: a5135ee ("orangefs: implement vm_ops->fault") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Jan Kara <jack@suse.cz> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Cc: Martin Brandenburg <martin@omnibond.com> Cc: Mike Marshall <hubcap@omnibond.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent d081107 commit 4539722

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

mm/filemap.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2719,7 +2719,6 @@ int filemap_page_mkwrite(struct vm_fault *vmf)
27192719
sb_end_pagefault(inode->i_sb);
27202720
return ret;
27212721
}
2722-
EXPORT_SYMBOL(filemap_page_mkwrite);
27232722

27242723
const struct vm_operations_struct generic_file_vm_ops = {
27252724
.fault = filemap_fault,
@@ -2750,6 +2749,10 @@ int generic_file_readonly_mmap(struct file *file, struct vm_area_struct *vma)
27502749
return generic_file_mmap(file, vma);
27512750
}
27522751
#else
2752+
int filemap_page_mkwrite(struct vm_fault *vmf)
2753+
{
2754+
return -ENOSYS;
2755+
}
27532756
int generic_file_mmap(struct file * file, struct vm_area_struct * vma)
27542757
{
27552758
return -ENOSYS;
@@ -2760,6 +2763,7 @@ int generic_file_readonly_mmap(struct file * file, struct vm_area_struct * vma)
27602763
}
27612764
#endif /* CONFIG_MMU */
27622765

2766+
EXPORT_SYMBOL(filemap_page_mkwrite);
27632767
EXPORT_SYMBOL(generic_file_mmap);
27642768
EXPORT_SYMBOL(generic_file_readonly_mmap);
27652769

0 commit comments

Comments
 (0)