Add affinity support to TerraformRepository CRD

[clementsol]

We would like the Burrito runners to run on the same nodes as Hermit Crab for FinOps considerations.

The validation fails when trying to add the following code to a TerrafomRepository:

  affinity:
    podAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
      - labelSelector:
          matchExpressions:
          - key: "app.kubernetes.io/name"
            operator: In
            values:
            - burrito-hermitcrab

When looking at the code, it looks like the CRD is missing support for affinity, contrary to nodeSeletor for example.

[corrieriluca]

Thanks for your issue. The good news is that it's very simple to implement!

If you want to contribute, here is a breakdown of the implementation:

• Add a field for affinity in the OverrideRunnerSpec structure in api/v1alpha1/common.go
• Implement the override or merge strategy (between layer or repo) in the GetOverrideRunnerSpec function in the same file. In the case of affinity, I think the layer should override the repo.
• Update the tests in api/v1alpha1/common_test.go
• Assign the obtained affinity to the spec of the Pod that the TerraformRun Controller will create (here)
• Test on a local or non-production environment if it works correctly

[smeelock]

hi!
thanks for pointing out the changes 🙏 I opened a PR can you have a look?