Skip to content

pyls incorrectly requires that textDocument/didOpen be called before fufilling any requests #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ggilmore opened this issue Mar 21, 2018 · 0 comments

Comments

@ggilmore
Copy link

See this issue in the official LSP repo: microsoft/language-server-protocol#177

Per @debaumer's comment, language servers should be able to fulfill requests regardless of whether or not the text document is open.

For example, pyls will raise a KeyError if you call hover on a document that has not been opened yet. According to the above, this seems to be incorrect behavior - pyls should be able to read this document from disk and fulfill the hover request.

@ggilmore ggilmore changed the title pyls incorrectly requires that textDocument/didOpen be called before fufilling any requests pyls incorrectly requires that textDocument/didOpen be called before fufilling any requests Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant