Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Whitespaces be placed at the begging of a line #32466

Closed
ShaharNaveh opened this issue Mar 5, 2020 · 0 comments · Fixed by #33693
Closed

Should Whitespaces be placed at the begging of a line #32466

ShaharNaveh opened this issue Mar 5, 2020 · 0 comments · Fixed by #33693
Labels
Code Style Code style, linting, code_checks

Comments

@ShaharNaveh
Copy link
Member

As of our current code style guide we are placing whitespaces at the begging of the lines, Black had a discussion at psf/black#182 (psf/black#1132 (comment) sums all of that discussion) where they decided that when "Black" wraps long strings it will place the whitespace at the begging of the line.

I think that we should reconsider/open for discussion the placement of whitespaces over long strings.

@jbrockmendel jbrockmendel added the Code Style Code style, linting, code_checks label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants