Skip to content

PcrSlot wont compile if TPM2_PCR_SELECT_MAX != 4 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Superhepper opened this issue Jan 17, 2022 · 0 comments · Fixed by #317
Closed

PcrSlot wont compile if TPM2_PCR_SELECT_MAX != 4 #310

Superhepper opened this issue Jan 17, 2022 · 0 comments · Fixed by #317
Assignees
Labels
bug Something isn't working

Comments

@Superhepper
Copy link
Collaborator

Superhepper commented Jan 17, 2022

If a platform has defined TPM2_PCR_SELECT_MAX != 4. The PcrSlot enum will cause compilation failure. It expects the buffer to hold the bit field octets to be four bytes. It needs to support lower values of TPM2_PCR_SELECT_MAX as well.

And should produce an error if the selected slot cannot fit inside the octets specified by TPM2_PCR_SELECT_MAX.

@Superhepper Superhepper added the bug Something isn't working label Jan 17, 2022
@Superhepper Superhepper self-assigned this Jan 17, 2022
@Superhepper Superhepper linked a pull request Jan 29, 2022 that will close this issue
@Superhepper Superhepper mentioned this issue Jan 30, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant