Skip to content

feat: Add PFUser.unregisterAuthenticationDelegate and allow to register delegate gracefully if another delegate is already registered #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Feb 22, 2023

New Pull Request Checklist

Issue Description

SDK asserts that auth delegate can only be registered once.

Closes: #n/a

Approach

Gracefully deregister existing auth delegate and register new delegate instead of crashing.

TODOs before merging

n/a

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: allow to register auth delegate gracefully if already registered feat: Allow to register auth delegate gracefully if already registered Feb 22, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 22, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza changed the title feat: Allow to register auth delegate gracefully if already registered feat: Allow to register PFUserAuthenticationDelegate gracefully if already registered Feb 22, 2023
@mtrezza mtrezza changed the title feat: Allow to register PFUserAuthenticationDelegate gracefully if already registered feat: Allow to register PFUserAuthenticationDelegate gracefully if delegate is already registered Feb 22, 2023
@mtrezza mtrezza changed the title feat: Allow to register PFUserAuthenticationDelegate gracefully if delegate is already registered feat: Allow to register PFUserAuthenticationDelegate gracefully if a delegate is already registered Feb 22, 2023
@mtrezza mtrezza changed the title feat: Allow to register PFUserAuthenticationDelegate gracefully if a delegate is already registered feat: Add PFUser.unregisterAuthType to unregister delegates; allow to register PFUserAuthenticationDelegate gracefully if a delegate is already registered Feb 22, 2023
@mtrezza mtrezza changed the title feat: Add PFUser.unregisterAuthType to unregister delegates; allow to register PFUserAuthenticationDelegate gracefully if a delegate is already registered feat: Add PFUser.unregisterAuthenticationDelegate to unregister delegates; allow to register PFUserAuthenticationDelegate gracefully if a delegate is already registered Feb 22, 2023
@mtrezza mtrezza changed the title feat: Add PFUser.unregisterAuthenticationDelegate to unregister delegates; allow to register PFUserAuthenticationDelegate gracefully if a delegate is already registered feat: Add PFUser.unregisterAuthenticationDelegate and allow to register delegate gracefully if another delegate is already registered Feb 22, 2023
@mtrezza mtrezza merged commit 0ef9351 into parse-community:master Feb 22, 2023
@mtrezza mtrezza deleted the fix-reregister-auth-delegate branch February 22, 2023 15:27
parseplatformorg pushed a commit that referenced this pull request Feb 22, 2023
# [2.1.0](2.0.3...2.1.0) (2023-02-22)

### Features

* Add `PFUser.unregisterAuthenticationDelegate` and allow to register delegate gracefully if another delegate is already registered ([#1711](#1711)) ([0ef9351](0ef9351))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 2.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants