-
-
Notifications
You must be signed in to change notification settings - Fork 137
remove request timeout in INTRA_CLUSTER_CLIENT #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
remove request timeout in INTRA_CLUSTER_CLIENT #1318
Conversation
current: timeout set to 30 secs change: remove timeout this is to ensure querier does not timeout while processing the request and prism does not throw exception to client which processing is still happening we still need to handle the scenario when there is a timeout set in client while prism is still processing a request
WalkthroughThe update removes the per-request timeout of 30 seconds from the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (10)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
current: timeout set to 30 secs
change: remove timeout
this is to ensure querier does not timeout while processing the request
and prism does not throw exception to client when processing is still happening
we still need to handle the scenario when there is a timeout set in client while prism is still processing a request
Summary by CodeRabbit