Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in URL #55

Closed
tbell511 opened this issue Nov 5, 2018 · 1 comment
Closed

Spaces in URL #55

tbell511 opened this issue Nov 5, 2018 · 1 comment

Comments

@tbell511
Copy link

tbell511 commented Nov 5, 2018

Should spaces in the URL cause the parser to return null to indicate a bad URL? Right now, the parser attempts to pull the domain and doesn't return null.

@jhnns
Copy link
Member

jhnns commented Nov 8, 2018

I think if we try to start parsing URLs more seriously, we're opening Pandora's box 😁. We'll leave the parsing stuff to the WHATWG URL constructor in the next major release: #14 (comment)

@jhnns jhnns closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants