Fix registration flow.

And default to requiring login for all views.

https://django-registration.readthedocs.io/en/stable/changelog.html#version-5-1-0

Author: trey

config/settings.py-tpl

@@ -71,6 +71,7 @@ MIDDLEWARE = [
     "django.middleware.common.CommonMiddleware",
     "django.middleware.csrf.CsrfViewMiddleware",
     "django.contrib.auth.middleware.AuthenticationMiddleware",
+    "django.contrib.auth.middleware.LoginRequiredMiddleware",
     "django.contrib.messages.middleware.MessageMiddleware",
     "django.middleware.clickjacking.XFrameOptionsMiddleware",
     "core.middleware.TimezoneMiddleware",

config/urls.py-tpl

@@ -32,6 +32,11 @@ urlpatterns = [
         auth_views.LoginView.as_view(redirect_authenticated_user=True),
         name="login",
     ),
+    path(
+        "accounts/register/complete/",
+        views.registration_complete,
+        name="django_registration_complete",
+    ),
     path(
         "accounts/register/",
         views.RegistrationView.as_view(
@@ -40,7 +45,7 @@ urlpatterns = [
         name="django_registration_register",
     ),
     path(
-        "accounts/activate/<str:activation_key>/",
+        "accounts/activate/",
         views.ActivationView.as_view(),
         name="django_registration_activate",
     ),

core/views.py-tpl

@@ -3,7 +3,7 @@ from django.contrib.auth import login
 from django.conf import settings
 from django.urls import reverse
 from django.http import FileResponse
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.decorators import login_not_required
 from django.contrib import messages
 from django.views.decorators.cache import cache_control
 from django.views.decorators.http import require_GET
@@ -17,24 +17,26 @@ from .utils import send_email_to_admin
 from .models import User
 
 
+@login_not_required
 def placeholder(request):
     context = {}
     return render(request, "placeholder.html", context)
 
 
-@login_required
 def private_page(request):
     context = {}
     return render(request, "private.html", context)
 
 
 @require_GET
+@login_not_required
 @cache_control(max_age=60 * 60 * 24, immutable=True, public=True)  # One day
 def favicon(request):
     file = (settings.BASE_DIR / "static" / "img" / "seahorse-64x64.png").open("rb")
     return FileResponse(file)
 
 
+@login_not_required
 def account_verified(request, user_id):
     user = get_object_or_404(User, id=user_id)
 
@@ -48,14 +50,23 @@ def account_verified(request, user_id):
     return redirect("index")
 
 
+@method_decorator(login_not_required, name="dispatch")
 class ActivationView(BaseActivationView):
-    def get_success_url(self, user):
+    def get_success_url(self, user=None):
+        if not User:
+            return reverse("index")
         return reverse("account-verified", args=(user.id,))
 
 
+@method_decorator(login_not_required, name="dispatch")
 @method_decorator(check_honeypot, name="post")
 class RegistrationView(BaseRegistrationView):
     def get(self, request, *args, **kwargs):
         if self.request.user.is_authenticated:
             return redirect("index")
         return super().get(request, *args, **kwargs)
+
+
+@login_not_required
+def registration_complete(request):
+    return render(request, "django_registration/registration_complete.html")

templates/django_registration/activation_email_body.txt

@@ -1,5 +1,5 @@
 Your're almost done creating your account
 
-Follow this link to activate it: {{ scheme }}://{{ site }}{% url 'django_registration_activate' activation_key %}
+Follow this link to activate it: {{ scheme }}://{{ site }}{% url 'django_registration_activate' %}?activation_key={{ activation_key }}
 
 The link expires in {{ expiration_days }} days, so get to it!

templates/django_registration/activation_form.html

@@ -0,0 +1,17 @@
+{% extends "base.html" %}
+
+{% block title %}
+  Complete your account activation
+{% endblock title %}
+
+{% block content %}
+  <h1>Complete your account activation</h1>
+
+  <form method="post">
+    {% csrf_token %}
+    <input type="hidden"
+           name="activation_key"
+           value="{{ request.GET.activation_key }}">
+    <button type="submit">Activate your account and log in</button>
+  </form>
+{% endblock content %}

templates/django_registration/registration_complete.html

@@ -1,5 +1,4 @@
 {% extends "base.html" %}
-{% load static %}
 
 {% block title %}
   Registration submitted