Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too-few-function-args overlaps with no-value-for-parameter #9881

Closed
rogersheu opened this issue Aug 19, 2024 · 0 comments · Fixed by #9882
Closed

too-few-function-args overlaps with no-value-for-parameter #9881

rogersheu opened this issue Aug 19, 2024 · 0 comments · Fixed by #9882
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Unreleased
Milestone

Comments

@rogersheu
Copy link
Contributor

rogersheu commented Aug 19, 2024

Bug description

I realized that the addition of a new message, too-few-function-args, in the recent PR #9847, overlaps with an existing message no-value-for-parameter.

    "E1120": (
        "No value for argument %s in %s call",
        "no-value-for-parameter",
        "Used when a function call passes too few arguments.",
    ),
    "E1145": (
        "Too few positional arguments for %s call",
        "too-few-function-args",
        "Used when a function or method call has fewer arguments than expected.",
    ),

Since no-value-for-parameter was the incumbent, it makes sense to keep it, unless we collectively decide otherwise. It may also be worth revisiting the contents/format of the message output by this check.

Configuration

No response

Command used

pylint "**/*.py"

Pylint output

************* Module isinstances
isinstances.py:4:0: E1145: Too few positional arguments for function call (too-few-function-args)
isinstances.py:5:0: E1145: Too few positional arguments for function call (too-few-function-args)

Expected behavior

************* Module isinstances
isinstances.py:4:0: E1120: No value for argument '__class_or_tuple' in function call (no-value-for-parameter)
isinstances.py:5:0: E1120: No value for argument '_obj' in function call (no-value-for-parameter)
isinstances.py:5:0: E1120: No value for argument '__class_or_tuple' in function call (no-value-for-parameter)

Pylint version

pylint 3.3.0.dev0

OS / Environment

No response

Additional dependencies

No response

Tasks

Preview Give feedback
No tasks being tracked yet.
@rogersheu rogersheu added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Aug 19, 2024
@rogersheu rogersheu changed the title Recently added message too-few-function-args overlaps in functionality with no-value-for-parameter Recently added message too-few-function-args overlaps with no-value-for-parameter Aug 19, 2024
@rogersheu rogersheu changed the title Recently added message too-few-function-args overlaps with no-value-for-parameter too-few-function-args overlaps with no-value-for-parameter Aug 19, 2024
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Unreleased and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Aug 19, 2024
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Unreleased
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants