Skip to content

Fix regression in test_step caused by #5131 #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ricardoV94 opened this issue Nov 3, 2021 · 1 comment · Fixed by #5135
Closed

Fix regression in test_step caused by #5131 #5134

ricardoV94 opened this issue Nov 3, 2021 · 1 comment · Fixed by #5135
Assignees
@ricardoV94
Labels
bug maintenance tests
Milestone
v4.0.0b1 (vNext)

Comments

@ricardoV94
Copy link
Member

The test failures are coming from #5131 because the Metropolis proposals are no longer following a global seeding, but several tests in test_step are based on this assumption.

Originally posted by @ricardoV94 in #5133 (comment)
@ricardoV94 ricardoV94 self-assigned this Nov 3, 2021
@ricardoV94
Copy link
Member Author

Let's make the Proposals raise when they don't have a rng_seed to catch up inappropriate uses and tests...

@ricardoV94 ricardoV94 added this to the v4.0.0-beta1 (vNext) milestone Nov 4, 2021
@ricardoV94 ricardoV94 mentioned this issue Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardoV94 ricardoV94

Labels
bug maintenance tests
Projects
None yet
Milestone
v4.0.0b1 (vNext)
Development

Successfully merging a pull request may close this issue.

Partially revert #5131 ricardoV94/pymc
1 participant
@ricardoV94