-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spread Windows CI load #6791
Comments
That's a great idea! I just want to point out that Travis CI also supports Windows so maybe it makes sense to also put 1-2 jobs there? |
My opinion: Travis's Windows support is experimental so I'd prefer to avoid it. 🤷🏻♂️ |
Which may mean that testing in another weird env can reveal more corner cases. |
One of the consequences of #6790 is that AppVeyor should now be "required" for CI. It's still the slowest CI we have, and it only has 1 runner for all PRs. I propose dropping the 3.6 integration tests from AppVeyor and moving it to Azure Pipelines. |
Fair enough |
Is this issue still relevant? Windows CI is split across four GHA jobs and are definitely not the slowest jobs today (MacOS jobs are, example). |
No, AppVeyor is no longer in use, neither is Azure Pipelines. And I don't think they're coming back since Pradyun mentioned getting the org into some plan with a lot more GHA compute for free in the winter. |
Follow-up of #6767
Current status:
8 interpreters (2.7, 3.5, 3.6 & 3.7 on x64 & x86) are tested.
Tests are split into 2 categories "unit" or "integration".
p
means tested on AppVeyor,z
means tested on Azure (andpz
on both)Azure
It takes:
and currently performs 8 unit + 2 integration in ~ 43 min
Appveyor
It takes:
and currently performs 6 unit + 2 integration in ~ 36 min
Suggestion
To remove all overlap and prefer x64 over x86 on Appveyor since it seems significantly faster (while appearing the same on Azure).
(Edited: this was a false impression, the difference came from python 2.7 vs 3.6 instead)
Azure would now be testing 5 unit + 2 inte (from 8 +2)
Appveyor would now be testing 3 unit + 3 inte (from 6 + 2)
Edited:
ERROR: virtualenv is not compatible with this system or executable
The text was updated successfully, but these errors were encountered: